This fixes issues related to breaking changes in latest versions of
GoPy, which will now return concrete instances of corresponding classes
in iterators; previously, only a "pointer" would be returned, which
would've then needed to be set as the handle for a newly created
instance of a relevant class.
Closes: #17
GoPy 0.4.8 and beyond introduce breaking changes related types returned
in function calls (e.g. slice element types). Previously, these would be
a pointer handle which would then need to be set into a concrete
instance of the type required by callers; GoPy will now return concrete
instances itself.
Moving to the new semantics requires changes to code, and additional
testing; pinning the version helps us migrate on our own timeline.
WhatsApp clients are set to accept only a specific set of media files as
image, audio, or video messages, specifically:
- Images must be in JPEG (non-progressive) format.
- Audio messages must be in Opus-encoded Ogg if sent as voice messages,
otherwise may be in MP3 or AAC format if not (though client support
may vary).
- Video messages must be in h264-encoded MP4, with some additional
constraints on color format and profile used.
Several edge-cases exist, e.g. with GIF files needing to be re-encoded
as MP4 in order to be animated (and requiring extra metadata in messages
to be called out as such).
This commit implements a somewhat comprehensive media conversion scheme,
built upon FFmpeg for audio and video, and native Go facilities for
images, based on the source format. Specifically:
- Audio files in `audio/mp4` or `audio/aac` format (corresponding to
formats commonly used in Android and iOS XMPP clients, respectively)
are automatically re-encoded as Opus-encoded voice messages.
- Audio files in `audio/mpeg` (i.e. MP3 files) or `audio/ogg` format
are sent as plain audio files in their own format, with varying client
support assumed.
- Images in `image/png` or `image/webp` format are automatically
re-encoded as JPEG image messages. Conversely, images in `image/gif`
format are re-encoded as MP4 video messages with auto-play enabled.
- Videos in `video/webm` or `video/mp4` format are automatically
re-encoded as MP4 video messages (the latter is re-encoded to ensure
option compatibility).
As stated above, all audio and video conversions require FFmpeg and
FFprobe to be installed, and, if missing, will leave attachments
unchanged (which may result these being sent as binary files). Image
conversions do not rely on any external functionality, however.
Current limits are: 10MiB for images and 20MiB for audio and video
files; above these conversions will fail and original files will be sent
instead.
Future commits may see compatibility improved, or semantics corrected
where these do not match expectations on the WhatsApp side.
nicoco
Alex Palaistras